lkml.org 
[lkml]   [2024]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/3] gpio: vf610: add support to DT 'ngpios' property
From
Hello Andy,

On 1/17/24 21:51, Andy Shevchenko wrote:
>> Some SoCs, such as i.MX93, don't have all 32 pins available
>> per port. Allow optional generic 'ngpios' property to be
>> specified from the device tree and default to
>> VF610_GPIO_PER_PORT (32) if the property does not exist.
>
> ...
>
>> + ret = device_property_read_u32(dev, "ngpios", &ngpios);
>> + if (ret || ngpios > VF610_GPIO_PER_PORT)
>> + gc->ngpio = VF610_GPIO_PER_PORT;
>> + else
>> + gc->ngpio = (u16)ngpios;
>
> This property is being read by the GPIOLIB core. Why do you need to repeat this?

My apologies; I had not seen this.
I'll use gpiochip_get_ngpios() on the next iteration.

Thank you!
--
Héctor Palacios


\
 
 \ /
  Last update: 2024-01-18 09:38    [W:0.086 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site