Messages in this thread | | | Date | Thu, 18 Jan 2024 16:49:42 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH v3 1/2] dt-bindings: reset: mediatek: add MT7988 reset IDs |
| |
On Wed, Jan 17, 2024 at 07:41:10PM +0100, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add reset constants for using as index in driver and dts. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > v3: > - add pcie reset id as suggested by angelo > > v2: > - add missing commit message and SoB > - change value of infrareset to 0 > --- > include/dt-bindings/reset/mediatek,mt7988-resets.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h > index 493301971367..0eb152889a89 100644 > --- a/include/dt-bindings/reset/mediatek,mt7988-resets.h > +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h > @@ -10,4 +10,10 @@ > /* ETHWARP resets */ > #define MT7988_ETHWARP_RST_SWITCH 0 > > +/* INFRA resets */ > +#define MT7988_INFRA_RST0_PEXTP_MAC_SWRST 0 > +#define MT7988_INFRA_RST1_THERM_CTRL_SWRST 1
These are just "random" numbers, why not continue the numbering from the ETHWARP?
> + > + > #endif /* _DT_BINDINGS_RESET_CONTROLLER_MT7988 */ > + > -- > 2.34.1 > [unhandled content-type:application/pgp-signature] | |