Messages in this thread Patch in this message | | | From | Denis Arefev <> | Subject | [PATCH] comedi: drivers: ni_tio: Fix arithmetic expression overflow | Date | Thu, 18 Jan 2024 15:37:47 +0300 |
| |
The value of an arithmetic expression period_ns * 1000 is subject to overflow due to a failure to cast operands to a larger data type before performing arithmetic
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 3e90b1c7ebe9 ("staging: comedi: ni_tio: tidy up ni_tio_set_clock_src() and helpers") Cc: <stable@vger.kernel.org> # v5.15+ Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Denis Arefev <arefev@swemel.ru> Signed-off-by: Ian Abbott <abbotti@mev.co.uk> --- drivers/comedi/drivers/ni_tio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/comedi/drivers/ni_tio.c b/drivers/comedi/drivers/ni_tio.c index da6826d77e60..acc914903c70 100644 --- a/drivers/comedi/drivers/ni_tio.c +++ b/drivers/comedi/drivers/ni_tio.c @@ -800,7 +800,7 @@ static int ni_tio_set_clock_src(struct ni_gpct *counter, GI_PRESCALE_X2(counter_dev->variant) | GI_PRESCALE_X8(counter_dev->variant), bits); } - counter->clock_period_ps = period_ns * 1000; + counter->clock_period_ps = period_ns * 1000UL; ni_tio_set_sync_mode(counter); return 0; } -- 2.25.1
| |