lkml.org 
[lkml]   [2024]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts
    On Thu, Jan 18, 2024 at 2:36 AM Qiang Yu <yuq825@gmail.com> wrote:
    >
    > So this is caused by same job trigger both done and timeout handling?
    > I think a better way to solve this is to make sure only one handler
    > (done or timeout) process the job instead of just making lima_pm_idle()
    > unique.

    It's not very clear to me how to best ensure that, with the drm_sched
    software timeout and the irq happening potentially at the same time.
    I think patch 4 in this series describes and covers the most common
    case that this would be hit. So maybe now this patch could be dropped
    in favour of just that one.
    But since this was a bit hard to reproduce and I'm not sure the issue
    is entirely covered by that, I just decided to keep this small change
    as it prevented all the stack trace reproducers I was able to come up
    with.

    Erico

    \
     
     \ /
      Last update: 2024-01-18 12:23    [W:2.773 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site