Messages in this thread |  | | Date | Wed, 17 Jan 2024 20:22:00 +1100 | | From | Tim Lunn <> | | Subject | Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for rk817 audio codec |
| |
On 1/17/24 04:06, Conor Dooley wrote: > On Wed, Jan 17, 2024 at 12:21:00AM +1100, Tim Lunn wrote: >> Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also >> using the same rk817_codec driver. However it is missing from the >> bindings. >> >> Update dt-binding documentation for rk809 to include the audio codec >> properties. This fixes the following warning from dtb check: >> >> pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', >> 'clock-names', 'clocks', 'codec' do not match any of the regexes: >> 'pinctrl-[0-9]+' >> >> Signed-off-by: Tim Lunn<tim@feathertop.org> >> --- >> >> (no changes since v1) >> >> .../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++- >> 1 file changed, 29 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml >> index 839c0521f1e5..bac2e751e2f2 100644 >> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml >> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml >> @@ -12,7 +12,7 @@ maintainers: >> >> description: | >> Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD >> - that includes regulators, an RTC, and power button. >> + that includes regulators, an RTC, a power button, and an audio codec. >> >> properties: >> compatible: >> @@ -93,6 +93,34 @@ properties: >> unevaluatedProperties: false >> unevaluatedProperties: false >> >> + clocks: >> + description: >> + The input clock for the audio codec. >> + >> + clock-names: >> + description: >> + The clock name for the codec clock. >> + items: >> + - const: mclk > You have one clock only, why do you need to have clock-names? This is just documenting the existing rk817 codec driver, which is using the name to get the clock:
devm_clk_get(pdev->dev.parent, "mclk");
Thus i dont think clock-names can be removed in this case? atleast not without patching the driver as well? > Otherwise, > Acked-by: Conor Dooley<conor.dooley@microchip.com> > > Cheers, > Conor. > >> + >> + '#sound-dai-cells': >> + description: >> + Needed for the interpretation of sound dais. >> + const: 0 >> + >> + codec: >> + description: | >> + The child node for the codec to hold additional properties. If no >> + additional properties are required for the codec, this node can be >> + omitted. >> + type: object >> + additionalProperties: false >> + properties: >> + rockchip,mic-in-differential: >> + type: boolean >> + description: >> + Describes if the microphone uses differential mode. >> + >> allOf: >> - if: >> properties: >> -- >> 2.40.1 >>
|  |