Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 16 Jan 2024 13:38:01 -0800 | Subject | Re: [PATCH 26/42] drivers/scsi/ibmvscsi_tgt: Convert snprintf to sysfs_emit | From | Tyrel Datwyler <> |
| |
On 1/15/24 20:51, Li Zhijian wrote: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > >> ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3619:8-16: WARNING: please use sysfs_emit >> ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3625:8-16: WARNING: please use sysfs_emit >> ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3633:8-16: WARNING: please use sysfs_emit > > No functional change intended > > CC: Michael Cyr <mikecyr@linux.ibm.com> > CC: "James E.J. Bottomley" <jejb@linux.ibm.com> > CC: "Martin K. Petersen" <martin.petersen@oracle.com> > CC: linux-scsi@vger.kernel.org > CC: target-devel@vger.kernel.org > Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> > ---
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
| ![\](/images/icornerr.gif) |