Messages in this thread |  | | From | "Rafael J. Wysocki" <> | | Date | Mon, 15 Jan 2024 16:52:26 +0100 | | Subject | Re: [PATCH v1] thermal/debugfs: Remove unnecessary debugfs_create_dir() error check in thermal_debug_init() |
| |
On Mon, Jan 15, 2024 at 9:25 AM Minjie Du <duminjie@vivo.com> wrote: > > This patch removes the debugfs_create_dir() error checking in > thermal_debug_init(). Because the debugfs_create_dir() is developed > in a way that the caller can safely handle the errors that > occur during the creation of DebugFS nodes.
I honestly don't see what the purpose of this patch is.
> Signed-off-by: Minjie Du <duminjie@vivo.com> > --- > drivers/thermal/thermal_debugfs.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/thermal/thermal_debugfs.c b/drivers/thermal/thermal_debugfs.c > index a3fa09235da1..695253559a61 100644 > --- a/drivers/thermal/thermal_debugfs.c > +++ b/drivers/thermal/thermal_debugfs.c > @@ -172,12 +172,8 @@ struct thermal_debugfs { > void thermal_debug_init(void) > { > d_root = debugfs_create_dir("thermal", NULL); > - if (!d_root) > - return; > > d_cdev = debugfs_create_dir("cooling_devices", d_root); > - if (!d_cdev) > - return; > > d_tz = debugfs_create_dir("thermal_zones", d_root); > } > --
|  |