Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] wifi: ath11k: document HAL_RX_BUF_RBM_SW4_BM | Date | Sun, 14 Jan 2024 17:17:39 +0200 |
| |
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> Commit 7636c9a6e7d7 ("wifi: ath11k: Add multi TX ring support for WCN6750") > added HAL_RX_BUF_RBM_SW4_BM to enum hal_rx_buf_return_buf_manager. However, > as flagged by the kernel-doc script, the documentation was not updated: > > drivers/net/wireless/ath/ath11k/hal.h:689: warning: Enum value 'HAL_RX_BUF_RBM_SW4_BM' not described in enum 'hal_rx_buf_return_buf_manager' > > So update the documentation. No functional changes, compile tested only. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
I'm not really a fan of kernel-doc in wireless drivers, it feels more unnecessary work. Should we remove the kernel-doc markings from ath11k altogether?
-- https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |