Messages in this thread | | | Date | Sat, 9 Sep 2023 11:42:27 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2 10/11] x86/alternatives: Simplify ALTERNATIVE_n() |
| |
On Sat, Sep 09, 2023 at 11:25:54AM +0200, Peter Zijlstra wrote: > This becomes more of a problem with your example above where the > respective lengths are 0, 5, 16. In that case, when you patch 5, you'll > leave 11 single nops in there. > > So what that code you deleted does is look for all alternatives that > start at the same point and computes the max replacementlen, because > that is the amount of bytes in the source text that has been reserved > for this alternative. > > That is not optional.
Note that the original alternatives did this with the alt_max_*() macro at build time.
| |