Messages in this thread | | | Date | Sat, 9 Sep 2023 11:33:27 +0530 | From | Manivannan Sadhasivam <> | Subject | Re: [PATCH] mtd: nand: qcom: Fix the node for nand unmap resource |
| |
On Thu, Sep 07, 2023 at 02:58:54PM +0530, Bibek Kumar Patro wrote: > While unmapping the nand resource in case of err_core_clk > the dev node being passed is res_start instead of nand->dma_base > (where the iova returned from map operation is stored) causing > failure in unmap operation. Hence modifying the unmap operation > to pass the nand->base_dma instead of res_start. > > Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com> > --- > drivers/mtd/nand/raw/qcom_nandc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c > index f583022755a2..e085a0f588eb 100644 > --- a/drivers/mtd/nand/raw/qcom_nandc.c > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > @@ -3322,7 +3322,7 @@ static int qcom_nandc_probe(struct platform_device *pdev) > err_aon_clk: > clk_disable_unprepare(nandc->core_clk); > err_core_clk: > - dma_unmap_resource(dev, res->start, resource_size(res), > + dma_unmap_resource(dev, nandc->base_dma, resource_size(res), > DMA_BIDIRECTIONAL, 0); > dev_err(&pdev->dev, "DEBUG: probe failed for nandc module\n");
This error indicates that you are sending the patch against downstream tree. That's not appropriate. Please send your patches against mainline/mtd-next instead and also validate properly.
- Mani
> return ret; > -- > 2.17.1 >
-- மணிவண்ணன் சதாசிவம்
| |