lkml.org 
[lkml]   [2023]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] x86: Remove the arch_calc_vm_prot_bits() macro from the uapi
From
On 9/6/23 09:26, Thomas Huth wrote:
> The arch_calc_vm_prot_bits() macro uses VM_PKEY_BIT0 etc. which are
> not part of the uapi, so the macro is completely useless for userspace.
> It is also hidden behind the CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
> config switch which we shouldn't expose to userspace. Thus let's move
> this macro into a new internal header instead.
>
> Fixes: 8f62c883222c ("x86/mm/pkeys: Add arch-specific VMA protection bits")
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Gah, sorry this got dropped. I went to go throw it in my review queue
and saw your last version in there. I plan to apply it (this time)
shortly after we see -rc1.

In any case:

Acked-by: Dave Hansen <dave.hansen@intel.com>

\
 
 \ /
  Last update: 2023-09-06 19:04    [W:0.065 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site