Messages in this thread | | | Date | Wed, 6 Sep 2023 18:41:16 +0200 | From | Simon Horman <> | Subject | Re: [PATCH net] net: enetc: distinguish error from valid pointers in enetc_fixup_clear_rss_rfs() |
| |
On Wed, Sep 06, 2023 at 05:16:09PM +0300, Vladimir Oltean wrote: > enetc_psi_create() returns an ERR_PTR() or a valid station interface > pointer, but checking for the non-NULL quality of the return code blurs > that difference away. So if enetc_psi_create() fails, we call > enetc_psi_destroy() when we shouldn't. This will likely result in > crashes, since enetc_psi_create() cleans up everything after itself when > it returns an ERR_PTR(). > > Fixes: f0168042a212 ("net: enetc: reimplement RFS/RSS memory clearing as PCI quirk") > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/netdev/582183ef-e03b-402b-8e2d-6d9bb3c83bd9@moroto.mountain/ > Suggested-by: Dan Carpenter <dan.carpenter@linaro.org> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Simon Horman <horms@kernel.org>
| |