Messages in this thread | | | Date | Wed, 6 Sep 2023 16:40:39 +0200 | Subject | Re: [PATCH v1 1/1] bitops: Share BYTES_TO_BITS() for everyone | From | Alexander Lobakin <> |
| |
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: Thu, 31 Aug 2023 16:21:30 +0300
> On Fri, Aug 25, 2023 at 04:49:07PM +0200, Alexander Lobakin wrote: >> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Date: Thu, 24 Aug 2023 15:37:28 +0300 >> >>> It may be new callers for the same macro, share it. >>> >>> Note, it's unknown why it's represented in the current form instead of >>> simple multiplication and commit 1ff511e35ed8 ("tracing/kprobes: Add >>> bitfield type") doesn't explain that neither. Let leave it as is and >>> we may improve it in the future. >> >> Maybe symmetrical change in tools/ like I did[0] an aeon ago? > > Hmm... Why can't you simply upstream your version? It seems better than mine.
It was a part of the Netlink bigint API which is a bit on hold for now (I needed this macro available treewide). But I can send it as standalone if you're fine with that.
> >> [0] >> https://github.com/alobakin/linux/commit/fd308001fe6d38837fe820427209a6a99e4850a8 >
Thanks, Olek
| |