lkml.org 
[lkml]   [2023]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] staging: vme_user: Fix block comments where '*' on each line should be aligned
On Tue, Sep 05, 2023 at 09:46:32PM +0200, Jonathan Bergh wrote:
> Fixed checkpatch warnings where lines with '*' in block comments should
> be aligned and were not as well as incorrect tab spacings at the start of
> comment lines.
>
> Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
> ---
> drivers/staging/vme_user/vme_tsi148.h | 140 +++++++++++++-------------
> 1 file changed, 70 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index dbdf5dabaf90..9748b7897527 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -251,28 +251,28 @@ static const int TSI148_LCSR_VIACK[8] = { 0, TSI148_LCSR_VIACK1,
> */
> #define TSI148_LCSR_VMEFL 0x250
>
> - /*
> - * VME exception.
> - * offset 260
> +/*
> + * VME exception.
> + * offset 260

Your patch doesn't introduce this but it should be hex 0x260 instead of
decimal 260. Same for all the other comments.

> */
> #define TSI148_LCSR_VEAU 0x260
> #define TSI148_LCSR_VEAL 0x264
> #define TSI148_LCSR_VEAT 0x268

regards,
dan carpenter

\
 
 \ /
  Last update: 2023-09-06 10:54    [W:0.046 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site