Messages in this thread | | | Date | Wed, 6 Sep 2023 10:23:23 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] sched/fair: Add SMT4 group_smt_balance handling |
| |
On Tue, Sep 05, 2023 at 10:54:09AM -0700, Tim Chen wrote:
> > > + goto fully_busy; > > > + break; > > > > This is really daft; why can't this simply be: fallthrough; ? At the > > very least that break must go. > > > > > > Yes, the break should go. I was adding the goto to prevent compiler > from complaining about fall through code.
But that's what we have the fallthrough keyword for, no?
| |