lkml.org 
[lkml]   [2023]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched/fair: Add SMT4 group_smt_balance handling
On Tue, Sep 05, 2023 at 10:54:09AM -0700, Tim Chen wrote:

> > > + goto fully_busy;
> > > + break;
> >
> > This is really daft; why can't this simply be: fallthrough; ? At the
> > very least that break must go.
> >
> >
>
> Yes, the break should go. I was adding the goto to prevent compiler
> from complaining about fall through code.

But that's what we have the fallthrough keyword for, no?

\
 
 \ /
  Last update: 2023-09-06 10:25    [W:0.090 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site