Messages in this thread | | | Date | Wed, 6 Sep 2023 14:18:23 -0700 | From | Ira Weiny <> | Subject | Re: [PATCH RFC v2 17/18] tools/testing/cxl: Add DC Regions to mock mem data |
| |
Jonathan Cameron wrote: > On Mon, 28 Aug 2023 22:21:08 -0700 > Ira Weiny <ira.weiny@intel.com> wrote: > > > To test DC regions the mock memory devices will need to store > > information about the regions and manage fake extent data. > > > > Define mock_dc_region information within the mock memory data. Add > > sysfs entries on the mock device to inject and delete extents. > > > > The inject format is <start>:<length>:<tag> > > The delete format is <start> > > > > Add DC mailbox commands to the CEL and implement those commands. > > > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > Looks fine to me. Totally trivial comment inline. > > FWIW > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > + > > static int mock_gsl(struct cxl_mbox_cmd *cmd) > > { > > if (cmd->size_out < sizeof(mock_gsl_payload)) > > @@ -1315,6 +1429,148 @@ static int mock_activate_fw(struct cxl_mockmem_data *mdata, > > return -EINVAL; > > } > > > > Bit inconsistent on whether there are one or two blank lines between functions.
I missed this one in my internal review. There should be no inconsistency... always 1 unless I messed up! :-D
Thanks, Ira
| |