lkml.org 
[lkml]   [2023]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH libnvme v2 2/2] fabrics: Do not pass disable_sqflow if not supported
Date
From: Sagi Grimberg <sagi@grimberg.me>

Only retry a connect attempt with disable_sqflow if the kernel
actually supports this option.

Reported-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
src/nvme/fabrics.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/nvme/fabrics.c b/src/nvme/fabrics.c
index 9725eeb3cda8..f0e85d3b766d 100644
--- a/src/nvme/fabrics.c
+++ b/src/nvme/fabrics.c
@@ -1043,7 +1043,8 @@ nvme_ctrl_t nvmf_connect_disc_entry(nvme_host_t h,
if (!ret)
return c;

- if (errno == EINVAL && c->cfg.disable_sqflow) {
+ if (errno == EINVAL && c->cfg.disable_sqflow &&
+ nvmf_check_option(h->r, disable_sqflow)) {
errno = 0;
/* disable_sqflow is unrecognized option on older kernels */
nvme_msg(h->r, LOG_INFO, "failed to connect controller, "
--
2.41.0
\
 
 \ /
  Last update: 2023-08-08 21:17    [W:2.066 / U:2.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site