lkml.org 
[lkml]   [2023]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/2] iio: adc: mcp3911: add support for the whole MCP39xx family
From
On 08/08/2023 09:22, Marcus Folkesson wrote:

>>
>> ...
>>
>>> - ret = mcp3911_config(adc);
>>> + ret = device_property_read_u32(&adc->spi->dev, "microchip,device-addr", &adc->dev_addr);
>>
>> Why not spi->dev? Ditto for other uses like this.
>
> After all, I think it is better to stick sith adc->spi-dev to be
> consistent with the rest of the probe function. Change to spi->dev
> should probably be a seperate patch.
> Do you agree?
>

You can first simplify the usages and then add new family support
already using spi->dev.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-08-08 21:08    [W:0.038 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site