lkml.org 
[lkml]   [2023]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [patch 19/53] x86/mpparse: Remove the physid_t bitmap wrapper
On Mon, Aug 7, 2023 at 4:53 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> physid_t is a wrapper around bitmap. Just remove the onion layer and use
> bitmap functionality directly.

...

> #include <linux/clockchips.h>
> #include <linux/interrupt.h>
> #include <linux/memblock.h>

> +#include <linux/bitmap.h>

Hmm... What is the ordering here? Reversed xmas tree?
Otherwise wouldn't it be better to put this before clockchips.h?

> #include <linux/ftrace.h>
> #include <linux/ioport.h>
> #include <linux/export.h>

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2023-08-08 20:56    [W:0.827 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site