Messages in this thread | | | Date | Wed, 9 Aug 2023 01:38:55 +0200 | From | Florian Westphal <> | Subject | Re: [PATCH 1/7] netfilter: ipset: refactor deprecated strncpy |
| |
Justin Stitt <justinstitt@google.com> wrote: > Fixes several buffer overread bugs present in `ip_set_core.c` by using > `strscpy` over `strncpy`. > > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Justin Stitt <justinstitt@google.com> > > --- > There exists several potential buffer overread bugs here. These bugs > exist due to the fact that the destination and source strings may have > the same length which is equal to the max length `IPSET_MAXNAMELEN`.
There is no truncation. Inputs are checked via nla_policy:
[IPSET_ATTR_SETNAME2] = { .type = NLA_NUL_STRING, .len = IPSET_MAXNAMELEN - 1 },
| |