Messages in this thread | | | From | Pankaj Gupta <> | Subject | RE: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added nxp secure enclave fw | Date | Tue, 8 Aug 2023 11:49:34 +0000 |
| |
> -----Original Message----- > From: Pankaj Gupta > Sent: Tuesday, August 8, 2023 5:04 PM > To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > clin@suse.com; conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai > <ping.bai@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>; Wei Fang > <wei.fang@nxp.com>; Peng Fan <peng.fan@nxp.com>; Bough Chen > <haibo.chen@nxp.com>; festevam@gmail.com; dl-linux-imx <linux- > imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain > <gaurav.jain@nxp.com>; alexander.stein@ew.tq-group.com; Sahil Malhotra > <sahil.malhotra@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>; Varun > Sethi <V.Sethi@nxp.com> > Subject: RE: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added > nxp secure enclave fw > > > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Sent: Thursday, July 13, 2023 12:38 AM > > To: Pankaj Gupta <pankaj.gupta@nxp.com>; shawnguo@kernel.org; > > s.hauer@pengutronix.de; kernel@pengutronix.de; clin@suse.com; > > conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai > > <ping.bai@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>; Wei Fang > > <wei.fang@nxp.com>; Peng Fan <peng.fan@nxp.com>; Bough Chen > > <haibo.chen@nxp.com>; festevam@gmail.com; dl-linux-imx <linux- > > imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org; > > krzysztof.kozlowski+dt@linaro.org; > > linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain > > <gaurav.jain@nxp.com>; alexander.stein@ew.tq-group.com; Sahil Malhotra > > <sahil.malhotra@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>; > Varun > > Sethi <V.Sethi@nxp.com> > > Subject: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added > > nxp secure enclave fw > > > > Caution: This is an external email. Please take care when clicking > > links or opening attachments. When in doubt, report the message using > > the 'Report this email' button > > > > > > On 12/07/2023 14:12, Pankaj Gupta wrote: > > > Added support for NXP secure enclave called EdgeLock Enclave > > > firmware > > > (se-fw) for imx93-11x11-evk. > > > > > > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com> > > > --- > > > arch/arm64/boot/dts/freescale/imx93.dtsi | 11 ++++++++++- > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > > > b/arch/arm64/boot/dts/freescale/imx93.dtsi > > > index 8643612ace8c..2b0f901d2709 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > > > @@ -1,6 +1,6 @@ > > > // SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > /* > > > - * Copyright 2022 NXP > > > + * Copyright 2022-2023 NXP > > > */ > > > > > > #include <dt-bindings/clock/imx93-clock.h> @@ -863,5 +863,14 @@ > > > ddr-pmu@4e300dc0 { > > > reg = <0x4e300dc0 0x200>; > > > interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; > > > }; > > > + > > > + ele_fw: se-fw { > > > + compatible = "fsl,imx93-ele"; > > > + mboxes = <&s4muap 0 0 &s4muap 1 0>; > > > > This should be two entries. > > > > > + mbox-names = "tx", "rx"; > > > + fsl,mu-did = <3>; > > > + fsl,mu-id = <2>; > > > > Drop both. Since you put it into the DTSI, it means it is compatible specific. > [Pankaj] Removed the above three entries.
[Pankaj] Correction: I missed to note that in our up-coming SoC(s), there will be multiple MU(s): Those can only be identified using mu_id. Hence, following two only, will be removed: + mbox-names = "tx", "rx"; + fsl,mu-did = <3>;
> > > > > > + status = "okay"; > > > > Drop. > [Pankaj] Accepted. > > > > > > > > Best regards, > > Krzysztof
| |