Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 8 Aug 2023 15:39:38 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v2 03/12] iommu: Remove unrecoverable fault data |
| |
On Fri, Aug 04, 2023 at 03:51:30AM +0000, Tian, Kevin wrote: > > From: Baolu Lu <baolu.lu@linux.intel.com> > > Sent: Friday, August 4, 2023 10:59 AM > > > > On 2023/8/3 15:54, Tian, Kevin wrote: > > >> From: Lu Baolu<baolu.lu@linux.intel.com> > > >> Sent: Thursday, July 27, 2023 1:48 PM > > >> > > >> struct iommu_fault { > > >> __u32 type; > > >> - __u32 padding; > > > this padding should be kept. > > > > > > > To keep above 64-bit aligned, right? > > > > yes
If it is not uapi we should not explicitly document padding (and __u32 should be u32). The compiler will add it if it is necessary.
If the compiler isn't right for some reason then something else has gone wrong.
Jason
| ![\](/images/icornerr.gif) |