lkml.org 
[lkml]   [2023]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] firmware: cs_dsp: Fix new control name check
    On Fri, Aug 04, 2023 at 11:52:12AM -0500, Vlad Karpovich wrote:
    > Before adding a new FW control, its name is checked against
    > existing controls list. But the string length in strncmp used
    > to compare controls names is taken from the list, so if beginnings
    > of the controls are matching, then the new control is not created.
    > For example, if CAL_R control already exists, CAL_R_SELECTED
    > is not created.
    > The fix is to compare string lengths as well.
    >
    > Fixes: 6477960755fb ("ASoC: wm_adsp: Move check for control existence")
    > Signed-off-by: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
    > ---

    Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

    Thanks,
    Charles

    \
     
     \ /
      Last update: 2023-08-08 21:50    [W:4.303 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site