Messages in this thread | | | Date | Mon, 7 Aug 2023 17:06:33 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v2 3/3] lib/vsprintf: Declare no_hash_pointers in sprintf.h |
| |
On Sat 2023-08-05 20:50:27, Andy Shevchenko wrote: > Sparse is not happy to see non-static variable without declaration: > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static? > > Declare respective variable in the sprintf.h. With this, add a comment > to discourage its use if no real need. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/linux/sprintf.h | 2 ++ > lib/test_printf.c | 2 -- > mm/kfence/report.c | 3 +--
If we agreed to move sprintf() declarations into printk.h then this might go to printk.h as well.
Best Regards, Petr
| |