Messages in this thread | | | Date | Mon, 7 Aug 2023 15:58:33 +0200 | From | Simon Horman <> | Subject | Re: [PATCH net-next 03/10] mlx4: Replace the mlx4_interface.event callback with a notifier |
| |
On Fri, Aug 04, 2023 at 05:05:20PM +0200, Petr Pavlu wrote:
...
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_main.c b/drivers/net/ethernet/mellanox/mlx4/en_main.c
...
> @@ -326,6 +333,11 @@ static void *mlx4_en_add(struct mlx4_dev *dev) > mutex_init(&mdev->state_lock); > mdev->device_up = true; > > + /* register mlx4 core notifier */ > + mdev->mlx_nb.notifier_call = mlx4_en_event; > + err = mlx4_register_event_notifier(dev, &mdev->mlx_nb);
Hi Petr.
This fails to build because err isn't declared in this context.
> + WARN(err, "failed to register mlx4 event notifier (%d)", err); > + > return mdev; > > err_mr:
...
| |