Messages in this thread | | | From | Alexandru Ardelean <> | Date | Mon, 7 Aug 2023 15:02:08 +0300 | Subject | Re: [PATCH] reset: zynqmp: removed unneeded call to platform_set_drvdata() |
| |
On Mon, Aug 7, 2023 at 2:43 PM Andrei Coardos <aboutphysycs@gmail.com> wrote: > > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. >
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/reset/reset-zynqmp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c > index 59dc0ff9af9e..510c168d635f 100644 > --- a/drivers/reset/reset-zynqmp.c > +++ b/drivers/reset/reset-zynqmp.c > @@ -107,8 +107,6 @@ static int zynqmp_reset_probe(struct platform_device *pdev) > if (!priv->data) > return -EINVAL; > > - platform_set_drvdata(pdev, priv); > - > priv->rcdev.ops = &zynqmp_reset_ops; > priv->rcdev.owner = THIS_MODULE; > priv->rcdev.of_node = pdev->dev.of_node; > -- > 2.34.1 >
| |