Messages in this thread | | | From | Alexandru Ardelean <> | Date | Mon, 7 Aug 2023 14:58:54 +0300 | Subject | Re: [PATCH] reset: uniphier-glue: remove unneeded call to platform_set_drvdata() |
| |
On Mon, Aug 7, 2023 at 2:27 PM Andrei Coardos <aboutphysycs@gmail.com> wrote: > > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. >
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/reset/reset-uniphier-glue.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/reset/reset-uniphier-glue.c b/drivers/reset/reset-uniphier-glue.c > index 15abac9fc72c..df41b75786ad 100644 > --- a/drivers/reset/reset-uniphier-glue.c > +++ b/drivers/reset/reset-uniphier-glue.c > @@ -99,8 +99,6 @@ static int uniphier_glue_reset_probe(struct platform_device *pdev) > priv->rdata.rcdev.of_node = dev->of_node; > priv->rdata.active_low = true; > > - platform_set_drvdata(pdev, priv); > - > return devm_reset_controller_register(dev, &priv->rdata.rcdev); > } > > -- > 2.34.1 >
| |