Messages in this thread | | | Date | Mon, 7 Aug 2023 16:48:24 +0530 | Subject | Re: [PATCH v7 8/8] kbuild: modinst: do modules_install step by step | From | Shreenidhi Shedi <> |
| |
On 06/08/23 12:15, Greg KH wrote: > On Sun, Aug 06, 2023 at 12:30:22AM +0530, Shreenidhi Shedi wrote: >> On 04/08/23 19:36, Greg KH wrote: >>> On Fri, Jun 23, 2023 at 08:23:58PM +0530, Shreenidhi Shedi wrote: >>>> Currently Makefile.modinst does three tasks on each module built: >>>> - Install modules >>>> - Sign modules >>>> - Compress modules >>>> >>>> All the above tasks happen from a single place. >>>> >>>> This patch divides this task further and uses a different makefile for >>>> each task. >>>> Signing module logic is completely refactored and everything happens >>>> from a shell script now. >>>> >>>> Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com> >>>> --- >>>> scripts/Makefile.compress | 53 ++++++++++++++++++ >>>> scripts/Makefile.install | 66 +++++++++++++++++++++++ >>>> scripts/Makefile.modinst | 111 +++----------------------------------- >>>> scripts/Makefile.sign | 37 +++++++++++++ >>>> scripts/signfile.sh | 24 +++++++++ >>>> 5 files changed, 186 insertions(+), 105 deletions(-) >>>> create mode 100644 scripts/Makefile.compress >>>> create mode 100644 scripts/Makefile.install >>>> create mode 100644 scripts/Makefile.sign >>>> create mode 100755 scripts/signfile.sh >>> >>> As you are touching the build process, you should always cc: the proper >>> mailing list, and the KBUILD maintainer. Please do so for this series, >>> as that is the proper tree for this to go through. >>> >>> thanks, >>> >>> greg k-h >> >> Thanks for the inputs Greg. >> >> CC-ing linux-kbuild@vger.kernel.org as suggested. > > This doesn't actually do anything, sorry. Please resend the whole > patchset again and add the proper people and list. > > thanks, > > greg k-h
Done. Addressed comments from Masahiro Yamada and sent a new patch series, hopefully I have added everyone this time :) Thanks.
-- Shedi
| |