Messages in this thread | | | Date | Mon, 7 Aug 2023 10:49:27 +0530 | Subject | Re: [PATCH 06/13] arm64: dts: ti: k3-j7200: Enable OSPI nodes at the board level | From | Dhruva Gole <> |
| |
On 03/08/23 02:23, Andrew Davis wrote: > OSPI nodes defined in the top-level J7200 SoC dtsi files are incomplete > and may not be functional unless they are extended with pinmux and > device information. > > As the attached OSPI device is only known about at the board integration > level, these nodes should only be enabled when provided with this > information.
Agree
> > Disable the OSPI nodes in the dtsi files and only enable the ones that > are actually pinned out on a given board. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 1 + > arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index ee7860913c387..571eb0e2eac92 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -544,6 +544,7 @@ ospi0: spi@47040000 { > power-domains = <&k3_pds 103 TI_SCI_PD_EXCLUSIVE>; > #address-cells = <1>; > #size-cells = <0>; > + status = "disabled"; > }; > }; > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi > index b37f4f88ece4f..5a300d4c8ba03 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi > @@ -267,6 +267,7 @@ eeprom@50 { > }; > > &ospi0 { > + status = "okay";
Reviewed-by: Dhruva Gole <d-gole@ti.com>
> pinctrl-names = "default"; > pinctrl-0 = <&mcu_fss0_ospi0_pins_default>; >
-- Thanks and Regards, Dhruva Gole
| |