lkml.org 
[lkml]   [2023]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: remove unneeded __meminit annotation
On Tue, Aug 08, 2023 at 09:58:31AM +0800, Miaohe Lin wrote:
> kswapd_stop() and kcompactd_stop() are only called when MEMORY_HOTREMOVE
> is enabled. So wrap them under CONFIG_MEMORY_HOTREMOVE and further remove
> __meminit annotation. No functional change intended.

I don't understand why this is an improvement. If CONFIG_MEMORY_HOTREMOVE
is disabled, the linker drops this section (... right?) If it's enabled,
then it gets shunted off into a cold section. So it seems like this
patch strictly makes things worse. But maybe I misunderstood.

\
 
 \ /
  Last update: 2023-08-08 04:32    [W:0.121 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site