Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 8 Aug 2023 03:31:01 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH] mm: remove unneeded __meminit annotation |
| |
On Tue, Aug 08, 2023 at 09:58:31AM +0800, Miaohe Lin wrote: > kswapd_stop() and kcompactd_stop() are only called when MEMORY_HOTREMOVE > is enabled. So wrap them under CONFIG_MEMORY_HOTREMOVE and further remove > __meminit annotation. No functional change intended.
I don't understand why this is an improvement. If CONFIG_MEMORY_HOTREMOVE is disabled, the linker drops this section (... right?) If it's enabled, then it gets shunted off into a cold section. So it seems like this patch strictly makes things worse. But maybe I misunderstood.
| ![\](/images/icornerr.gif) |