lkml.org 
[lkml]   [2023]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 7/9] i2c: dln2: Use dev_err_probe in probe function
    Date
    Use the dev_err_probe function instead of dev_err in the probe function
    so that the printed messge includes the return value and also handles
    -EPROBE_DEFER nicely.

    Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
    Signed-off-by: Liao Chang <liaochang1@huawei.com>
    ---
    drivers/i2c/busses/i2c-dln2.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-dln2.c b/drivers/i2c/busses/i2c-dln2.c
    index 4f02cc2fb567..631109c7a098 100644
    --- a/drivers/i2c/busses/i2c-dln2.c
    +++ b/drivers/i2c/busses/i2c-dln2.c
    @@ -218,10 +218,8 @@ static int dln2_i2c_probe(struct platform_device *pdev)

    /* initialize the i2c interface */
    ret = dln2_i2c_enable(dln2, true);
    - if (ret < 0) {
    - dev_err(dev, "failed to initialize adapter: %d\n", ret);
    - return ret;
    - }
    + if (ret < 0)
    + return dev_err_probe(dev, ret, "failed to initialize adapter\n");

    /* and finally attach to i2c layer */
    ret = i2c_add_adapter(&dln2->adapter);
    --
    2.25.1
    \
     
     \ /
      Last update: 2023-08-08 03:31    [W:2.129 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site