Messages in this thread | | | From | Alexandru Ardelean <> | Date | Mon, 7 Aug 2023 20:38:27 +0300 | Subject | Re: [PATCH] spi: gxp: removed unneeded call to platform_set_drvdata() |
| |
On Mon, Aug 7, 2023 at 4:27 PM Mark Brown <broonie@kernel.org> wrote: > > On Mon, Aug 07, 2023 at 04:02:17PM +0300, Andrei Coardos wrote: > > > This function call was found to be unnecessary as there is no equivalent > > platform_get_drvdata() call to access the private data of the driver. Also, > > the private data is defined in this driver, so there is no risk of it being > > accessed outside of this driver file. > > That isn't enough of a check here - people can still reference the > driver data without going through the accessor function.
So, is that like calling `platform_get_drvdata()` in a parent/chid device, to check if the driver-data is set? Would it make sense for another driver to do that (i.e. check the driver-data is non-null, but not access the data)? I can imagine that being possible, but it's a bit quirky.
Or, is the issue with the wording of the comment?
| |