Messages in this thread | | | Date | Thu, 31 Aug 2023 18:05:06 +0200 | From | Michael Büsch <> | Subject | Re: [PATCH] ssb-main: Fix division by zero in ssb_calc_clock_rate() |
| |
On Thu, 31 Aug 2023 10:07:33 +0300 (MSK) Ранд Дееб <deeb.rand@confident.ru> wrote:
> 1- Yes, I agree that your solution is simpler, and I thought about > it, but I thought that the one who set the value zero put it for some > reason, so I did not want to change it.
Yes, I understand your reasoning and I had the same thought initially. But I looked into the code and I am pretty sure that there is no reason for the default case returning 0. In fact, I think returning a 1 as default makes much more sense as the default value for a factor.
Changing this from 0 to 1 will get my ack.
-- Michael Büsch https://bues.ch/ [unhandled content-type:application/pgp-signature] | |