Messages in this thread | | | Date | Thu, 31 Aug 2023 16:54:30 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH v4 1/3] dt-bindings: hwmon: Add Infineon TDA38640 |
| |
On Thu, Aug 31, 2023 at 12:49:32AM +0530, Naresh Solanki wrote: > Hi > > On Wed, 30 Aug 2023 at 21:02, Conor Dooley <conor@kernel.org> wrote: > > On Wed, Aug 30, 2023 at 12:36:16PM +0200, Naresh Solanki wrote:
> > > + Indicates that the chip ENABLE pin is at fixed level or left > > > + unconnected(has internal pull-down). > > > > Maybe you've already been over this, but if the pin is called "enable" > > why not use the same wording in the property? > EN & ENABLE is used interchangeably in the datasheet.
Maybe we can go 1 for 2 in terms of consistency then, rather than 0 for 2.
> Just to keep property name short I use EN.
Consistency & readability trump brevity. Please pick one term, or point out that this is called two things in the datasheet.
[unhandled content-type:application/pgp-signature] | |