Messages in this thread | | | Date | Thu, 31 Aug 2023 15:30:19 +0530 | Subject | Re: [PATCH 3/4] dt-bindings: clock: qcom: Add GCC clocks for SM4450 | From | Ajit Pandey <> |
| |
On 8/24/2023 11:40 PM, Krzysztof Kozlowski wrote: > On 24/08/2023 19:34, Ajit Pandey wrote: >> Add support for qcom global clock controller bindings for SM4450 platform. >> >> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com> >> --- >> .../bindings/clock/qcom,sm4450-gcc.yaml | 54 +++++ >> include/dt-bindings/clock/qcom,sm4450-gcc.h | 197 ++++++++++++++++++ >> 2 files changed, 251 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm4450-gcc.yaml >> create mode 100644 include/dt-bindings/clock/qcom,sm4450-gcc.h >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm4450-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm4450-gcc.yaml >> new file mode 100644 >> index 000000000000..8c767bdf7f9d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/qcom,sm4450-gcc.yaml >> @@ -0,0 +1,54 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/qcom,sm4450-gcc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Global Clock & Reset Controller on SM4450 >> + >> +maintainers: >> + - Ajit Pandey <quic_ajipan@quicinc.com> >> + - Taniya Das <quic_tdas@quicinc.com> >> + >> +description: | >> + Qualcomm global clock control module provides the clocks, resets and power >> + domains on SM4450 >> + >> + See also:: include/dt-bindings/clock/qcom,sm4450-gcc.h >> + >> +properties: >> + compatible: >> + const: qcom,sm4450-gcc >> + >> + clocks: >> + items: >> + - description: Board XO source >> + - description: Sleep clock source >> + - description: UFS Phy Rx symbol 0 clock source (Optional clock) >> + - description: UFS Phy Rx symbol 1 clock source (Optional clock) >> + - description: UFS Phy Tx symbol 0 clock source (Optional clock) >> + - description: USB3 Phy wrapper pipe clock source (Optional clock) > > I doubt that these are really optional clocks. They are set as parents > of your clocks in the controller, so if these clocks are physically > missing, how does the clock controller work? > > > Best regards, > Krzysztof >
Yeah, if these optional clocks are missing, few dependent child clocks functionality (UFS/USB) will not work and clock controller will work with limited functionality, but I agree that the tag "Optional Clock" is bit confusing here and will remove this in next patch series.
-- Thanks, and Regards Ajit
| |