Messages in this thread | | | Date | Fri, 1 Sep 2023 02:24:59 +0300 | From | Andy Shevchenko <> | Subject | Re: [RFT PATCH] spi: bcm2835: reduce the abuse of the GPIO API |
| |
On Thu, Aug 31, 2023 at 09:49:34PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Currently the bcm2835 SPI driver uses functions meant for GPIO providers > exclusively to locate the GPIO chip it gets its CS pins from and request > the relevant pin. I don't know the background and what bug forced this.
...
> /* > + * TODO: The code below is a slightly better alternative to the utter > + * abuse of the GPIO API that I found here before. It creates a > + * temporary lookup table, assigns it to the SPI device, gets the GPIO > + * descriptor and then releases the lookup table. > * > + * Still the real problem is unsolved. Looks like the cs_gpiods table > + * is not assigned correctly from DT? > */
I'm not sure why this quirk is here. AFAIR the SPI CS quirks are located in gpiolib-of.c.
-- With Best Regards, Andy Shevchenko
| |