lkml.org 
[lkml]   [2023]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs
From
On Wed Aug 23, 2023 at 11:23 AM EEST, Paul Menzel wrote:
> Dear Jarkko,
>
>
> Thank you for your patch.
>
>
> Am 23.08.23 um 01:15 schrieb Jarkko Sakkinen:
> > The vendor check introduced by commit 554b841d4703 ("tpm: Disable RNG for
> > all AMD fTPMs") doesn't work properly on a number of Intel fTPMs. On the
> > reported systems the TPM doesn't reply at bootup and returns back the
> > command code. This makes the TPM fail probe.
> >
> > Since only Microsoft Pluton is the only known combination of AMD CPU and
> > fTPM from other vendor, disable hwrng otherwise. In order to make sysadmin
> > aware of this, print also info message to the klog.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 554b841d4703 ("tpm: Disable RNG for all AMD fTPMs")
> > Reported-by: Todd Brandt <todd.e.brandt@intel.com>
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217804
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> Mario’s patch also had the three reporters below listed:
>
> Reported-by: Patrick Steinhardt <ps@pks.im>
> Reported-by: Ronan Pigott <ronan@rjp.ie>
> Reported-by: Raymond Jay Golo <rjgolo@gmail.com>

The problem here is that checkpatch throws three warnings:

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#19:
Reported-by: Patrick Steinhardt <ps@pks.im>
Reported-by: Ronan Pigott <ronan@rjp.ie>

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#20:
Reported-by: Ronan Pigott <ronan@rjp.ie>
Reported-by: Raymond Jay Golo <rjgolo@gmail.com>

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#21:
Reported-by: Raymond Jay Golo <rjgolo@gmail.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

Since bugzilla is not part of the documented process afaik, I used this
field as the guideline:

Reported: 2023-08-17 20:59 UTC by Todd Brandt

How otherwise I should interpret kernel bugzilla?

In any case new version is still needed as the commit message must
contain a mention of "Lenovo Legion Y540" as the stimulus for doing
this code change in the first place.

BR, Jarkko

\
 
 \ /
  Last update: 2023-08-23 19:40    [W:0.102 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site