lkml.org 
[lkml]   [2023]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 10/12] KVM: x86/mmu: Use BUILD_BUG_ON_INVALID() for KVM_MMU_WARN_ON() stub
    From
    Hi Sean,

    On 29/7/23 02:47, Sean Christopherson wrote:
    > Use BUILD_BUG_ON_INVALID() instead of an empty do-while loop to stub out
    > KVM_MMU_WARN_ON() when CONFIG_KVM_PROVE_MMU=n, that way _some_ build
    > issues with the usage of KVM_MMU_WARN_ON() will be dected even if the
    > kernel is using the stubs, e.g. basic syntax errors will be detected.
    >
    > Signed-off-by: Sean Christopherson <seanjc@google.com>
    > ---
    > arch/x86/kvm/mmu/mmu_internal.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
    > index 40e74db6a7d5..f1ef670058e5 100644
    > --- a/arch/x86/kvm/mmu/mmu_internal.h
    > +++ b/arch/x86/kvm/mmu/mmu_internal.h
    > @@ -9,7 +9,7 @@
    > #ifdef CONFIG_KVM_PROVE_MMU
    > #define KVM_MMU_WARN_ON(x) WARN_ON_ONCE(x)
    > #else
    > -#define KVM_MMU_WARN_ON(x) do { } while (0)
    > +#define KVM_MMU_WARN_ON(x) BUILD_BUG_ON_INVALID(x)

    No need to include <linux/build_bug.h> ? Anyhow,

    Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

    > #endif
    >

    \
     
     \ /
      Last update: 2023-08-01 16:05    [W:2.827 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site