Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 1 Aug 2023 21:25:37 +0800 | Subject | Re: [PATCH 3/3] arm64: dts: Replace the IRQ number with the IRQID macro definition | From | Huqiang Qin <> |
| |
Hi Kevin,
On 2023/7/29 3:06, Kevin Hilman wrote: >> On 2023/7/27 6:33, Kevin Hilman wrote: >>>> Replacing IRQ numbers with IRQID macro definitions makes node properties >>>> easier to understand and also makes GPIO interrupts easier to use. >>>> >>>> Associated platforms: >>>> - Amlogic Meson-G12A >>>> - Amlogic Meson-G12B >>>> - Amlogic Meson-SM1 >>> Does this mean you tested/validated these changes on those platforms >>> also? >> >> Amlogic's G12A/G12B/SM1 have the same GPIO, and the GPIO interrupt number >> is also the same, so I only tested on the SM1 platform, and the test results >> prove that these changes are good. > > OK, thank you for the explanation. > > For future reference, this kind of detail is helpful to describe in the > patch or cover letter so maintainers & reviewers better understand how > the changes were tested.
Thanks for the suggestion, I'll add it to the cover letter for the patch v3. (patch v2 was sent before your reply)
Best Regards, Huqiang Qin
| ![\](/images/icornerr.gif) |