Messages in this thread | | | Date | Tue, 1 Aug 2023 16:19:30 +0300 | Subject | Re: [RFC PATCH] net: ethernet: ti: am65-cpsw-qos: Add Frame Preemption MAC Merge support | From | Roger Quadros <> |
| |
On 01/08/2023 16:14, Vladimir Oltean wrote: > On Tue, Jul 25, 2023 at 10:23:38AM +0300, Roger Quadros wrote: >> Add driver support for viewing / changing the MAC Merge sublayer >> parameters and seeing the verification state machine's current state >> via ethtool. >> >> As hardware does not support interrupt notification for verification >> events we resort to polling on link up. On link up we try a couple of >> times for verification success and if unsuccessful then give up. >> >> The Frame Preemption feature is described in the Technical Reference >> Manual [1] in section: >> 12.3.1.4.6.7 Intersperced Express Traffic (IET – P802.3br/D2.0) >> >> Due to Silicon Errata i2208 [2] we set limit min IET fragment size to 124. >> >> [1] AM62x TRM - https://www.ti.com/lit/ug/spruiv7a/spruiv7a.pdf >> [2] AM62x Silicon Errata - https://www.ti.com/lit/er/sprz487c/sprz487c.pdf >> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> >> --- > > Also: > > ../drivers/net/ethernet/ti/am65-cpsw-qos.c:173:6: warning: no previous prototype for function 'am65_cpsw_iet_change_preemptible_tcs' [-Wmissing-prototypes] > void am65_cpsw_iet_change_preemptible_tcs(struct am65_cpsw_port *port, u8 preemptible_tcs) > ^ > ../drivers/net/ethernet/ti/am65-cpsw-qos.c:173:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > void am65_cpsw_iet_change_preemptible_tcs(struct am65_cpsw_port *port, u8 preemptible_tcs) > ^ > static > ../drivers/net/ethernet/ti/am65-cpsw-qos.c:179:6: warning: no previous prototype for function 'am65_cpsw_iet_link_state_update' [-Wmissing-prototypes] > void am65_cpsw_iet_link_state_update(struct net_device *ndev) > ^ > ../drivers/net/ethernet/ti/am65-cpsw-qos.c:179:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > void am65_cpsw_iet_link_state_update(struct net_device *ndev) > ^ > static > ../drivers/net/ethernet/ti/am65-cpsw-qos.c:699:33: error: redefinition of 'taprio' > struct tc_taprio_qopt_offload *taprio = type_data; > ^ > ../drivers/net/ethernet/ti/am65-cpsw-qos.c:697:33: note: previous definition is here > struct tc_taprio_qopt_offload *taprio = type_data; > ^ > 2 warnings and 1 error generated. > make[7]: *** [../scripts/Makefile.build:243: drivers/net/ethernet/ti/am65-cpsw-qos.o] Error 1 > make[7]: *** Waiting for unfinished jobs....
I'm pretty sure there weren't any build errors for me. Did you have and resolve conflicts when applying this patch?
-- cheers, -roger
| |