Messages in this thread | ![/](/images/icornerl.gif) | | From | chengdong zhou <> | Date | Tue, 1 Aug 2023 15:27:04 +0800 | Subject | Re: [PATCH] USB: gadget: Fix the function name error in sourcesink/loopback. |
| |
Thank you for your patient response.
On Tue, Aug 1, 2023 at 2:23 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > Please document this in the changelog text.
But I can't find the changelog text anywhere.
> > > But you changed the name: > > > > > - ss->function.name = "source/sink"; > > > > + ss->function.name = "sourcesink"; > > isn't that visable to userspace?
Yes, I removed the "/". Because the macro definition DECLARE_USB_FUNCTION_INIT does not support "/". Should I stick with the original "SourceSink"? I think using the Linux-style "sourcesink" is better. By the way, due to the current bug, no one should be able to use "source/sink" in userspace.
thanks.
| ![\](/images/icornerr.gif) |