lkml.org 
[lkml]   [2023]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 10/10] ext4: correct some stale comment of criteria
    Kemeng Shi <shikemeng@huaweicloud.com> writes:

    > We named criteria with CR_XXX, correct stale comment to criteria with
    > raw number.
    >
    > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
    > ---
    > fs/ext4/mballoc.c | 8 ++++----
    > 1 file changed, 4 insertions(+), 4 deletions(-)
    >
    > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
    > index bfaab173a3f4..1e8ce0ece47a 100644
    > --- a/fs/ext4/mballoc.c
    > +++ b/fs/ext4/mballoc.c
    > @@ -2782,8 +2782,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
    >
    > /*
    > * ac->ac_2order is set only if the fe_len is a power of 2
    > - * if ac->ac_2order is set we also set criteria to 0 so that we
    > - * try exact allocation using buddy.
    > + * if ac->ac_2order is set we also set criteria to CR_POWER2_ALIGNED
    > + * so that we try exact allocation using buddy.
    > */
    > i = fls(ac->ac_g_ex.fe_len);
    > ac->ac_2order = 0;
    > @@ -2840,8 +2840,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
    > /*
    > * Batch reads of the block allocation bitmaps
    > * to get multiple READs in flight; limit
    > - * prefetching at cr=0/1, otherwise mballoc can
    > - * spend a lot of time loading imperfect groups
    > + * prefetching at inexpensive CR, otherwise mballoc
    > + * can spend a lot of time loading imperfect groups
    > */
    > if ((prefetch_grp == group) &&
    > (ext4_mb_cr_expensive(cr) ||
    Is this function defined at any place ^^^

    -ritesh

    \
     
     \ /
      Last update: 2023-08-02 03:20    [W:4.034 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site