Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 1 Aug 2023 16:11:39 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v4 1/4] kernel.h: Split out COUNT_ARGS() and CONCATENATE() to args.h |
| |
On Wed, Jul 19, 2023 at 12:11:44AM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > The COUNT_ARGS() and CONCATENATE() macros may be used in some places > without need of the full kernel.h dependency train with it. > > Here is the attempt on cleaning it up by splitting out these macros(). > > While at it, include new header where it's being used. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com> # PCI
> diff --git a/include/linux/pci.h b/include/linux/pci.h > index 0ff7500772e6..eeb2e6f6130f 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -23,7 +23,7 @@ > #ifndef LINUX_PCI_H > #define LINUX_PCI_H > > - > +#include <linux/args.h> > #include <linux/mod_devicetable.h> > > #include <linux/types.h>
If there's not a reason otherwise, I'd put this in the main list instead of the weirdly separated mod_devicetable.h.
| ![\](/images/icornerr.gif) |