Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Tue, 1 Aug 2023 21:22:55 +0200 | Subject | Re: [PATCH] gpio: palmas: remove unnecessary call to platform_set_drvdata() |
| |
On Fri, Jul 28, 2023 at 7:59 PM Andrei Coardos <aboutphysycs@gmail.com> wrote: > > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > > Reviewed-by: Alexandru Ardelean <alex@shruggie.ro> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/gpio/gpio-palmas.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-palmas.c b/drivers/gpio/gpio-palmas.c > index bac10c2faf56..dd8a287ff6d0 100644 > --- a/drivers/gpio/gpio-palmas.c > +++ b/drivers/gpio/gpio-palmas.c > @@ -184,7 +184,6 @@ static int palmas_gpio_probe(struct platform_device *pdev) > return ret; > } > > - platform_set_drvdata(pdev, palmas_gpio); > return ret; > } > > -- > 2.34.1 >
Applied, thanks!
Bartosz
| |