lkml.org 
[lkml]   [2023]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] gpio: max77620: remove unneeded platform_set_drvdata() call
On Tue, Jul 25, 2023 at 2:36 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call is not required because no counterpart
> platform_get_drvdata() call is present to leverage the private data of
> the driver.
> Since the private data is confined to this driver file, external access
> is not feasible.
> The use of this function appears redundant in the current context of the
> driver's implementation.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>
> Changelog V1->V2:
>
> * https://lore.kernel.org/linux-gpio/20230720132535.23413-1-aboutphysycs@gmail.com/
> * fixed subject line: adjusted colons where needed
>
> drivers/gpio/gpio-max77620.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
> index c18b60e39a94..8c2a5609161f 100644
> --- a/drivers/gpio/gpio-max77620.c
> +++ b/drivers/gpio/gpio-max77620.c
> @@ -331,8 +331,6 @@ static int max77620_gpio_probe(struct platform_device *pdev)
> girq->init_hw = max77620_gpio_irq_init_hw;
> girq->threaded = true;
>
> - platform_set_drvdata(pdev, mgpio);
> -
> ret = devm_gpiochip_add_data(&pdev->dev, &mgpio->gpio_chip, mgpio);
> if (ret < 0) {
> dev_err(&pdev->dev, "gpio_init: Failed to add max77620_gpio\n");
> --
> 2.34.1
>

Applied, thanks!

Bartosz

\
 
 \ /
  Last update: 2023-08-01 21:23    [W:0.044 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site