lkml.org 
[lkml]   [2023]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 05/10] ext4: remove unnecessary return for void function
    Date
    The return at end of void function is unnecessary, just remove it.

    Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
    Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
    ---
    fs/ext4/mballoc.c | 10 +---------
    1 file changed, 1 insertion(+), 9 deletions(-)

    diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
    index acf8e3183e47..2f26a91595ca 100644
    --- a/fs/ext4/mballoc.c
    +++ b/fs/ext4/mballoc.c
    @@ -4876,7 +4876,6 @@ static void ext4_mb_generate_from_freelist(struct super_block *sb, void *bitmap,
    mb_set_bits(bitmap, entry->efd_start_cluster, entry->efd_count);
    n = rb_next(n);
    }
    - return;
    }

    /*
    @@ -5630,12 +5629,10 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac)
    #else
    static inline void ext4_mb_show_pa(struct super_block *sb)
    {
    - return;
    }
    static inline void ext4_mb_show_ac(struct ext4_allocation_context *ac)
    {
    ext4_mb_show_pa(ac->ac_sb);
    - return;
    }
    #endif

    @@ -5876,12 +5873,9 @@ static void ext4_mb_add_n_trim(struct ext4_allocation_context *ac)
    spin_unlock(&lg->lg_prealloc_lock);

    /* Now trim the list to be not more than 8 elements */
    - if (lg_prealloc_count > 8) {
    + if (lg_prealloc_count > 8)
    ext4_mb_discard_lg_preallocations(sb, lg,
    order, lg_prealloc_count);
    - return;
    - }
    - return ;
    }

    /*
    @@ -6535,7 +6529,6 @@ static void ext4_mb_clear_bb(handle_t *handle, struct inode *inode,
    error_return:
    brelse(bitmap_bh);
    ext4_std_error(sb, err);
    - return;
    }

    /**
    @@ -6638,7 +6631,6 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode,
    }

    ext4_mb_clear_bb(handle, inode, block, count, flags);
    - return;
    }

    /**
    --
    2.30.0
    \
     
     \ /
      Last update: 2023-08-01 08:32    [W:5.938 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site