Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 04 Jul 2023 21:30:51 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH] sh: provide unxlate_dev_mem_ptr() in asm/io.h |
| |
On Tue, Jul 4, 2023, at 21:01, Guenter Roeck wrote: > The unxlate_dev_mem_ptr() function has no prototype on the sh architecture, > which does not include asm-generic/io.h. This results in the following > build failure. > > drivers/char/mem.c: In function 'read_mem': > drivers/char/mem.c:164:25: error: implicit declaration of function > 'unxlate_dev_mem_ptr' > > This compile error is now seen because commit 99b619b37ae1 ("mips: provide > unxlate_dev_mem_ptr() in asm/io.h") removed the weak function which was > previously in place to handle the problem. > > Add a trivial macro to the sh header to provide the now missing dummy > function. > > Fixes: 99b619b37ae1 ("mips: provide unxlate_dev_mem_ptr() in asm/io.h") > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Ideally, we should use the asm-generic/io.h header here, but as a hotfix this should do.
Acked-by: Arnd Bergmann <arnd@arndb.de>
| ![\](/images/icornerr.gif) |