Messages in this thread | | | From | Micah Morton <> | Date | Tue, 4 Jul 2023 11:24:27 -0700 | Subject | Re: [PATCH v2] LSM: SafeSetID: fix UID printed instead of GID |
| |
On Wed, Jun 21, 2023 at 12:37 AM Aleksandr Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> wrote: > > On Wed, Jun 21, 2023 at 2:30 AM Paul Moore <paul@paul-moore.com> wrote: > > > > On Thu, Jun 8, 2023 at 2:34 PM Paul Moore <paul@paul-moore.com> wrote: > > > On Tue, Jun 6, 2023 at 5:13 PM Paul Moore <paul@paul-moore.com> wrote: > > > > On Tue, Jun 6, 2023 at 2:50 PM Aleksandr Mikhalitsyn > > > > <aleksandr.mikhalitsyn@canonical.com> wrote: > > > > > On Thu, May 18, 2023 at 8:59 PM Paul Moore <paul@paul-moore.com> wrote: > > > > > > On Wed, May 3, 2023 at 2:44 AM Alexander Mikhalitsyn > > > > > > <aleksandr.mikhalitsyn@canonical.com> wrote: > > > > > > > > > > > > > > pr_warn message clearly says that GID should be printed, > > > > > > > but we have UID there. Let's fix that. > > > > > > > > > > > > > > Found accidentaly during the work on isolated user namespaces. > > > > > > > > > > > > > > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> > > > > > > > --- > > > > > > > v2: __kuid_val -> __kgid_val > > > > > > > --- > > > > > > > security/safesetid/lsm.c | 2 +- > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > I'm assuming you're going to pick this up Micah? > > > > > > > > > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > > > > > > > > > Dear Paul! > > > > > > > > > > Thanks for your review! > > > > > > > > > > Gentle ping to Micah Morton :-) > > > > > > > > Micah? > > > > > > > > The right thing would be for Micah to merge this via the SafeSetID > > > > tree, however, considering that it's been over a month with no > > > > response, and this patch looks trivially correct, I can pick this up > > > > via the LSM tree if we don't see anything from Micah this week. > > > > > > Searching through all of the archives on lore I don't see any email > > > from Micah past August of 2022. I'll still stick to the plan of > > > merging this via the LSM tree next week if we don't see any response > > > from Micah, but beyond this patch we may need to consider the > > > possibility that Micah has moved on from SafeSetID.
Sorry guys, this is my first time checking my @chromium.org email in a couple months. I have indeed moved on from being regularly plugged in to the goings on of the linux-security-module mailing list. @Paul Moore whatever you think is the best way forward here is good for me, I can't really make any promises that I'll be checking this mailing list on a regular basis.
> > > > > > * https://lore.kernel.org/all/?q=f%3Amortonm%40chromium.org > > Hi Paul, > > > > > This fell through the cracks in my inbox last week, but I just went > > ahead and merged this into lsm/next. > > Thanks! > > Kind regards, > Alex > > > > > After the upcoming merge window closes we'll have to revisit > > SafeSetID's status as "supported", we might need to demote it to > > "maintained" or "odd fixes". > > > > -- > > paul-moore.com
| |