Messages in this thread | | | Date | Wed, 5 Jul 2023 02:14:10 +0800 | Subject | Re: drm/drm_gem.c: Remove surplus else after return | From | Sui Jingfeng <> |
| |
Hi, Thomas
On 2023/6/22 18:18, Sui Jingfeng wrote: > else is not generally useful after return > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/gpu/drm/drm_gem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > index 1a5a2cd0d4ec..c18686f434d4 100644 > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -1150,8 +1150,8 @@ int drm_gem_pin(struct drm_gem_object *obj) > { > if (obj->funcs->pin) > return obj->funcs->pin(obj); > - else > - return 0; > + > + return 0; > } > > void drm_gem_unpin(struct drm_gem_object *obj)
I have merge this patch with the dim tool, by using the following command,
./dim push-branch drm-misc-next
Is this looks fine?
I'm so worry about the dim tool now.
I want to make sure if I do the things correctly.
| |