Messages in this thread | | | Date | Tue, 4 Jul 2023 11:05:56 -0600 | Subject | Re: [PATCH] net: Replace strlcpy with strscpy | From | David Ahern <> |
| |
On 7/3/23 11:58 AM, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to remove strlcpy() completely [2], replace > strlcpy() here with strscpy(). > No return values were used, so direct replacement is safe. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > [2] https://github.com/KSPP/linux/issues/89 > > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> > --- > include/trace/events/fib.h | 2 +- > include/trace/events/fib6.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >
Reviewed-by: David Ahern <dsahern@kernel.org>
| |